"Johnduhart" posted a comment on MediaWiki.r100551. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100551#c28446
Commit summary for MediaWiki.r100551: Adding flatlists to HTMLRadioField, sort of like HTMLMultiSelect Johnduhart's comment: <blockquote>Can't you move that "flatlist" option straight in HTMLFormField? Fields that do not use 'flatlist' will just ignore it anyway and that will avoid us some code duplication.</blockquote> Sure. <blockquote>Lastly you wrap each radio with a <nowiki><div class="mw-htmlform-radio-item"></nowiki>, you could probably apply the class to the radio element instead.</blockquote> No because it needs to be applied to the label and input tags. <blockquote>Anyway, it looks like that <nowiki><div></nowiki> is intended to wrap all the radio button created. So you probably want to get that <nowiki><div></nowiki> outside of the foreach :)</blockquote> No, each need it. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
