"Kaldari" changed the status of Wikimedia.r1048 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1048#c28439
Old Status: deferred
> New Status: fixme
Commit summary for Wikimedia.r1048:
Added network handler to make command line calls.
Kaldari's comment:
<pre>
+ extract( $options );
</pre>
Since the only option you're using is 'execute' and it's getting set
explicitly, it doesn't look like there's any need to do an extract(). Also,
since you're only using a single option, wouldn't it be better to make $execute
an explicit parameter rather than hiding it inside $options:
<pre>
final public function terminal( $command, $execute = 'exec' ) {
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
