"Aaron Schulz" changed the status of MediaWiki.r103613 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103613#c27878
Old Status: fixme > New Status: ok Commit summary for MediaWiki.r103613: * Use ParserOptions::newFromContext() to not depend on $wgUser and $wgLang * Use a WikiPage object instead of Article to get the text or the ParserOutput and create the object directly in getParsedSectionOrText() * Use Title::getLatestRevID() instead of Article::getRevIdFetched() since the latter will always return the current revision ID when 0 is passed as second parameter to the constructor * Pass the User object to Revision::getText() * Removed double setting of $wgTitle Aaron Schulz's comment: Looks OK then. Not sure how to decrease the "reviewer anxiety" in this code, maybe with some comments. The current page text cannot be deleted, so the non-oldid case is fine too. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
