"Kaldari" posted a comment on MediaWiki.r101620. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101620#c27784
Commit summary for MediaWiki.r101620: Followup r101618: actually make things work. You can't feed HTML to mw.msg() (or it'll be escaped) and I was using .html() wrong Kaldari's comment: <pre> + var commonsLink = $( '<a>' ) + .attr( 'href', mw.msg( 'wikilove-commons-url' ) ) + .text( mw.msg( 'wikilove-commons-link' ) ) + .wrap( '<div>' ) // or .html() will only return the link text + .parent() + .html(); + termsLink = $( '<a> ') + .attr( 'href', mw.msg( 'wikilove-terms-url' ) ) + .text( mw.msg( 'wikilove-terms-link' ) ) + .wrap( '<div>' ) + .parent() + .html(); </pre> Looks like you probably either meant to use a comma instead of a semicolon, or are missing the 2nd var declaration. Fixed in r106395. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
