"Awjrichards" changed the status of MediaWiki.r106239 to "fixme" and commented
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106239#c27686
Old Status: ok
> New Status: fixme
Commit summary for MediaWiki.r106239:
follow-up to r105659, only connect to db when necessary, use better condition
statement
Awjrichards's comment:
Oops missed this the first time around:
<pre>
$result = $dbr->select(
'public_reporting_fundraisers',
'round( prf_total ) AS total',
- 'prf_id = ' . $myFundraiser['id'],
+ 'prf_id' => $myFundraiser['id'],
__METHOD__
);
</pre>
Syntax error! Should be:
<pre>
$result = $dbr->select(
'public_reporting_fundraisers',
'round( prf_total ) AS total',
array( 'prf_id' => $myFundraiser['id'] ),
__METHOD__
);
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
