"Krinkle" changed the status of MediaWiki.r106109 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106109#c27681
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r106109:
Data handling cleanup in DonationInterface, part 2 of [some].
ALL FORM CLASSES: Removed the $form_data array. All data will now be fetched
directly from the gateway adapter object via Gateway_Form::getEscapedValue().
Started work removing what will hopefully work out to be all instances of child
form classes touching $wgRequest or $wgOut directly: These will either be
functionalized and moved to Gateway_Form, added to the data population and
normalization routines in DonationData, or removed entirely.
Krinkle's comment:
<pre>
Index:
trunk/extensions/DonationInterface/globalcollect_gateway/forms/TwoStepAmount.php
===================================================================
---
trunk/extensions/DonationInterface/globalcollect_gateway/forms/TwoStepAmount.php
(revision 106108)
+++
trunk/extensions/DonationInterface/globalcollect_gateway/forms/TwoStepAmount.php
(revision 106109)
- $this->form_data['process'] = 'other';
+ $this->getEscapedValue( 'process' ) = 'other';
</pre>
<pre>
PHP Fatal error: Can't use method return value in write context in
/mw-extensions/DonationInterface/globalcollect_gateway/forms/TwoStepAmount.php
on line 80
</pre>
:''http://integration.mediawiki.org/ci/job/MediaWiki-lint/69/console''
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
