"Khorn (WMF)" changed the status of Wikimedia.r891 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/891#c27669
Old Status: new > New Status: fixme Commit summary for Wikimedia.r891: Added pushToQueueWithJmsCorrelationId(), fetchFromLimbo(), fetchFromLimboAndDequeue(), getQueueLimbo() and setQueueLimbo(). See r890 Khorn (WMF)'s comment: In fetchFromLimbo (and anywhere else you call stompFetchMessage): When you call stompFetchMessage, you probably want <pre>'ack' => 'client'</pre> in the properties array. Without the 'ack' property set to 'client' in the subscribe call, the message will ack automatically as soon as you pull it, which might not be readily apparent in testing. http://activemq.apache.org/stomp/stomp10/additional.html#ack_modes _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
