"Nikerabbit" changed the status of MediaWiki.r106113 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106113

Old status:  new
> New status: ok

Commit summary for MediaWiki.r106113:

parseChunkDelimiter is now newline agnostic

Under Windows, newline is \r\n. Thus we were passing a chunk delimiter ending
with a remaining \r and the chunk was never recognized. That caused an
exception to be thrown when CodeReview is installed on a Windows server.

rtrim() happilly makes this function agnostic.

added two tests cases to make sure we do not choke anymore on this issue.

Fix r94951

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to