"Awjrichards" changed the status of Wikimedia.r942 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/942#c27580
Old Status: new
> New Status: fixme
Commit summary for Wikimedia.r942:
Updated PSC Listener to handle database connections. Allowed listener to check
for messages in the limbo queue or in CiviCRM.
Awjrichards's comment:
In Listener.php:
<pre>
public static function setConfigurationFile( $path = '' )
{
$path = empty( $path ) ? '' : $path;
</pre>
This seems redundant and creates some unnecessary confusion - in either event,
you're essentially setting $path = $path, unless there's something I'm not
thinking of here?
Also, see comment for r475 about using extract(). In the cases here, the
parameters defined in the comments do not match up at all with how
extract($parameters) appears to be used.
I'm still reviewing the code base, so there will likely be further comments.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
