"Jeroen De Dauw" posted a comment on MediaWiki.r106059. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106059#c27532
Commit summary for MediaWiki.r106059: reverting r105766, does not work, also too hacky Jeroen De Dauw's comment: > Maybe instead of using blind offsets, you could use a regex. That would be > less likely to fail. So you'd be ok with this approach if I replace it by a regex? > Or, refactor it so that the other methods are returning a list of wikiText > arguments, and then construct the template string at the last minute. That > might be too much work though. I figured this would definitely be non-trivial to do, so yeah, it seems like to much work. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
