"Tim Starling" posted a comment on MediaWiki.r96158. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96158#c27172
Commit summary for MediaWiki.r96158: (bug 26084) add some ajax to easily delete tags TODO: implements functionality to add tags easily! Tim Starling's comment: The "+" and "⌫" do not look like buttons. Please replace them with images. You can get appropriate images from the [http://everaldo.com/crystal/crystal_project.tar.gz Crystal theme] or you can put simple placeholder images in there for now. I don't think the crosshair cursor is appropriate for a delete button, it's for drawing or for shooting alien invaders. In the AJAX success callback, you should check the response body to see if the request was actually successful, and pass the error message through to the user if it wasn't. As with r95435, the click handlers should be registered on DOM ready. Presumably tagAdd() is meant to be registered as a click handler for the plus sign and it's meant to do something. Reverting for now since this is incomplete and not deployable. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
