"Dantman" posted a comment on MediaWiki.r104274. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104274#c26749
Commit summary for MediaWiki.r104274: Implement path routing code. - Makes extending paths with extensions simpler. - Should fix bug 32621 by parsing paths based on pattern weight rather than pattern order. Dantman's comment: Erm... I figured out the bug. It had nothing to do directly with fr or unicode. I simply forgot to rawurldecode the stuff before putting it into $matches. So /wiki/Main%20Page would end up as <code>array( 'title' => "Main%20Page" )</code> instead of <code>array( 'title' => "Main Page" )</code> and the % would trigger badtitle. And of course fr uses unicode, so that triggers urlencoding which triggers the issue indirectly. Fixed, added tests for more edge cases I could think of, and re-added. If you can think of any other edge cases, putting them into the test suite would be good. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
