"Catrope" changed the status of MediaWiki.r103535 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103535#c26748
Old Status: deferred > New Status: ok Commit summary for MediaWiki.r103535: Added first node preservation when rebuilding Catrope's comment: What happens if, due to the optimization, newNodes is empty and remove becomes zero? Won't that cause splice() to fail? (The docs for splice() say it may fail in some browsers if you tell it to remove nothing and add nothing.) OK otherwise, marking OK. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
