User "Johnduhart" posted a comment on MediaWiki.r104384.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104384#c26597
Commit summary:
switched to arrays in response to r104381#c26594 - ty Johnduhart
Comment:
Much better, however still room for improvement. How about instead of
hardcoding the links you have a foreach loop that goes over an array of arrays.
Let's say I give you this as a configuration:
<pre>$wgAddThisSBServ = array(
array(
'type' => 'facebook',
),
array(
'type' => 'google_plusone',
'attribs' => 'g:plusone:count="false" style="margin-top:1px;"',
),
// Etc...
);</pre>
In my opinion this is much more cleaner than now.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
