User "Krinkle" changed the status of MediaWiki.r102770. Old Status: new New Status: fixme
User "Krinkle" also posted a comment on MediaWiki.r102770. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102770#c26593 Commit summary: Create ext.webfonts.init and ext.webfonts.core modules, set 'position' => 'top' for both of these modules so that they start loading and initializing from the head and only execute after document is ready. ext.webFonts.fontlist.js extends mw.webfonts.config object with the list of fonts and languages As per https://www.mediawiki.org/wiki/User:Krinkle/Extension_review/WebFonts Comment: Looks good! Just one small thing. <pre>+ config = {</pre> <code>config</code> is put in the global scope, make sure to make it local only by placing <code>var </code> in front of it. Marking fixme because of it, everything else is ok. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
