User "Aaron Schulz" posted a comment on MediaWiki.r103692.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103692#c26232
Commit summary:

(bug 30368) When a page is moved, link to and display the new name rather than 
the old name on Special:Newpages. Did this by treating relying on rc_cur_id 
instead of rc_namespace & rc_title when building the list. This is safe because 
the Newpages query already joins against page, so we know the rc_cur_id points 
to an existing page.

Comment:

This way adds a query per row.

It already JOINs on rc_cur_id=page_id. Why not just grab 
page_namespace,page_title and then use Title::newFromRow()?

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to