User "Catrope" posted a comment on MediaWiki.r102335. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102335#c25699 Commit summary:
Follow-up r102334: odd that this minus sign (yes, copied from a diff) was actually harmless. Also explicitly define a variable that would otherwise be lazily initialised to zero but about which my IDE complains. Comment: PHP was probably interpreting it as <code>-($this->toc .= blah)</code>, which would mean blah is appended to $this->toc, then the new value of $this->toc is returned from the parenthesized expression, then that value is cast to an integer (probably zero), then that value is negated (-0 = 0), then that value is discarded because it's not being assigned to anything. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
