User "Catrope" changed the status of MediaWiki.r101491. Old Status: ok New Status: fixme
User "Catrope" also posted a comment on MediaWiki.r101491. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101491#c25332 Commit summary: * Create all items in $nav_urls at the beginning so that we don't need to bother if they are set or not after that * Don't show 'whatlinkshere', 'recentchangeslinked' and 'trackbacklink' items if OutputPage::isArticleRelated() is false * Simplify the code to check if we show show user related items since the actual code is just to check if we have an User object * Moved the showEmailUser() check to the same location as other related user checks * Made Skin::showEmailUser() accept an User object instead of doing object -> int -> object conversion * Check if the items are present in BaseTemplate::getToolbox() instead of 'notspecialpage' and removed some empty() or isset() checks since all of these items are now set Comment: <pre> Notice: Undefined index: print in /home/catrope/mediawiki/trunk/phase3/includes/SkinTemplate.php on line 1459 Call Stack: 0.0001 657656 1. {main}() /home/catrope/mediawiki/trunk/phase3/index.php:0 0.0592 14151696 2. MediaWiki->run() /home/catrope/mediawiki/trunk/phase3/index.php:58 0.0593 14151696 3. MediaWiki->main() /home/catrope/mediawiki/trunk/phase3/includes/Wiki.php:519 0.1469 30854768 4. MediaWiki->finalCleanup() /home/catrope/mediawiki/trunk/phase3/includes/Wiki.php:601 0.1470 30854848 5. OutputPage->output() /home/catrope/mediawiki/trunk/phase3/includes/Wiki.php:381 0.1701 33328800 6. SkinTemplate->outputPage() /home/catrope/mediawiki/trunk/phase3/includes/OutputPage.php:1901 0.2831 41035824 7. VectorTemplate->execute() /home/catrope/mediawiki/trunk/phase3/includes/SkinTemplate.php:502 0.2948 41084264 8. VectorTemplate->renderPortals() /home/catrope/mediawiki/trunk/phase3/skins/Vector.php:211 0.2978 41090328 9. BaseTemplate->getToolbox() /home/catrope/mediawiki/trunk/phase3/skins/Vector.php:275 </pre> Reverting this revision makes the notice go away. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
