User "Platonides" posted a comment on MediaWiki.r98339. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98339#c25152 Commit summary:
* (bug 31204) Remove old user.user_options Added run of ConvertUserOptions maintenance script into update.php before dropping the column Removed usages of user_options in code Marked User::decodeOptions() deprecated as of 1.19. Made ConvertUserOptions drop out early if the user_options field doesn't exist Made ConvertUserOptions update user_options to '' after migration of user options to mOptions Comment: What about also dropping the removals of 'user_options' => '' at User::createNew and User::addToBDatabase in 1.18 ? They are inserts, so not listing them would give those columns the default value, which should be ''. And doing that we keep 1.18 forward compatible with 1.19 schema. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
