User "Catrope" posted a comment on MediaWiki.r101118.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101118#c25081
Commit summary:

Remove functionality: Loading form state from cookies, and clicking on username 
--> filter by that user

Comment:

<pre>
-       saveFormState();
-       var filterType = $( '#fbd-filters' ).children( 'form' ).data( 
'filtertype' );
-       // If filtering already happened on the PHP side, don't load the form 
state from cookies
-       if ( filterType != 'filtered' ) {
-               // Don't do an AJAX filter if we're on an ID view, or if the 
form is still blank after loadFromCookies()
-               if ( loadFromCookies() && filterType != 'id' ) {
-                       saveFormState();
-                       loadComments( 'filter' );
-               }
-       }
</pre>
Are you sure you want to remove this feature completely? It restores the 
checkbox states from the cookies, in addition to the username text box. Brandon 
specifically requested this feature in the first iteration of FBD.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to