User "Tim Starling" changed the status of MediaWiki.r95725. Old Status: deferred New Status: fixme
User "Tim Starling" also posted a comment on MediaWiki.r95725. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95725#c24867 Commit summary: rewrite udp2log multicast listen support Comment: <pre> Socket socket; socket = *(new UDPSocket()); </pre> This is less broken than the code that came before (I wrote a comment about it on r75452), but it still leaks memory and incorrectly does a copies the contents of a derived class to its parent class, a parent class which has a comment attached to it explicitly saying that it shouldn't be instantiated. I guess I will have to fix this and make Socket properly uncopyable, to avoid similar mistakes in the future. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
