User "Jack Phoenix" posted a comment on MediaWiki.r100103. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100103#c24489 Commit summary:
Major refactor to Video extension. Code for Video providers is less repetitive. Some providers however were lost, but can be brought back later. Comment: Awesome! :D At first seeing six instances of "(deleted)" on this CR page scared me a bit, but then I looked at the VideoClass.php diff and found out the reasoning for each and every removal. As for Archive.org, the code ''should'' work but I never tested it, I just copypasted it from Nef's YouTube extension (at trunk/extensions/YouTube) and modified accordingly; I dunno about Gamevideos, its code was also borrowed from the aforementioned YouTube extension. As for the other three, I don't think that it's such a big loss even if we'd completely drop support for those...besides, everyone and their aunt seems to be using Facebook instead of MySpace nowadays, so supporting their videos instead of MySpace's might be a smart idea. :) Should getProviderByURL() in VideoClass.php use parse_url() (as it currently does) or wfParseUrl()? If the usage of parse_url() there is intentional, you might want to add a code comment for future reviewers. Could you also update the [[Extension:Video|on-wiki extension page]] with up-to-date instructions on how to add a new video provider? All in all, great job — people like you make open source '''awesome'''! _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
