User "Hashar" changed the status of MediaWiki.r93702. Old Status: fixme New Status: ok
User "Hashar" also posted a comment on MediaWiki.r93702. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93702#c24481 Commit summary: mediawiki.Title: Removing public setter functions. Title object should be immutable. - To avoid repetition, instead of substituting, changed them to private helper functions - Updated test suite to create new objects for different titles, rather than modifying the existing one. - Adding missing unit tests, now 100% complete according to QUnit CompletnessTest + Test for Title.prototype.getNamespaceId + Test forTitle.prototype.getPrefixedText + Test forTitle.prototype.getExtension Follows-up r90331 CR Comment: That should be enough. Thanks for the tip :-) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
