User "Krinkle" posted a comment on MediaWiki.r93702. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93702#c24436 Commit summary:
mediawiki.Title: Removing public setter functions. Title object should be immutable. - To avoid repetition, instead of substituting, changed them to private helper functions - Updated test suite to create new objects for different titles, rather than modifying the existing one. - Adding missing unit tests, now 100% complete according to QUnit CompletnessTest + Test for Title.prototype.getNamespaceId + Test forTitle.prototype.getPrefixedText + Test forTitle.prototype.getExtension Follows-up r90331 CR Comment: <code>new mw.Title( 'NeilK', 'user_talk' );</code> Never did and still doesn't work, second argument to constructor must be namespace ID. setNamespace has been removed as Title should be immutable. So this case is no longer up for testing. <code>new mw.Title( 'user_talk:NeilK' );</code> should work though, do we test for that scenario ? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
