User "Catrope" posted a comment on MediaWiki.r98698. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98698#c23665 Commit summary:
FileCache: * Added FileCacheBase::*MissesRecent() functions for counting cache misses from different visitors. * Made ObjectFileCache more generic. * Cleaned up FileCacheBase::checkCacheDirs(). * Added FileCacheBase::typeSubdirectory() function and overwrote in HTMLFileCache. Fixes r98405 invalidating all existing cache due to directory change. * Simplified FileCacheBase::checkCacheDirs() a bit ResourceLoader: * Use ResourceFileCache to handle load() requests, if $wgUseFileCache. Only caches requests for default language and skins. Single modules requests are always cached, whereas others require a certain threshold of traffic. * Added ResourceFileCache class (functionality was initially to be in ObjectFileCache). Comment: <pre> + // Remove the output buffer and output the response + ob_end_clean(); </pre> You're not gonna output the warnings and such you gathered in the buffer? ResourceLoader bits look good to me otherwise. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
