User "Raymond" changed the status of MediaWiki.r98627.

Old Status: new
New Status: fixme

User "Raymond" also posted a comment on MediaWiki.r98627.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98627#c23622
Commit summary:

Fixing topics of rev. 96192

Comment:

Short i18n/l10n review:

# Please prefix all message keys with the extension name "freqpatterntagcloud-" 
or at least a abbreaviation like "fptc-". This avoids key conflicts with 
MediaWiki core and/or other extensions. 
# {{Messagedocumentation}}
# Code convention for message keys is all lowercase, using dashes, no 
underscores: i.e. "contextMenu_Browse" -> "fptc-context-menu-browse" (incl. 
prefix from 1)
# No uppercasing in message text: "Browse Pages With This Value" -> "Browse 
pages with this Value"
# Trailing spaces are ignored: "Do you mean: " -> "Do you mean:". If needed add 
a space to the code or use message 'word-separator'
# Use UTF-8 instead of HTML entities: "&Auml ;hnliche Tags" -> "Ähnliche Tags"
# Language 'de' is informell (Du): "Meinten Sie: " -> "Meintest du:". 
Translatewiki.net folks will fix this after your extension is added to 
Translatewiki.net
# I have not read your code, so maybe I am wrong here: Normally $1...$9 are 
used as variables: "Similar to \"%s\":" -> "Similar to \"$1\":"

After fixing 1.-6., maybe 8 too, I will add your extension to translatewiki.net.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to