User "Krinkle" posted a comment on MediaWiki.r98116. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98116#c23312 Commit summary:
MoodBar: Implement AJAX filtering in Special:MoodBarFeedback * Factor out comment loading code into loadComments(), and allow it to operate in two modes * Factor out display of errors/messages into showMessage() * When viewing a permalink, load form state from cookies but don't act on it. If filtering happened on the PHP side, leave the form state alone completely. To determine which state we're in, expose data-filtertype on the <form> element from PHP. * If there are no more results when filtering in PHP, hide the More link rather than not outputting it at all. We may need it later. Comment: <pre> - $username = $( '#fbd-filters-username' ); + $username = $( '#fbd-filters-username' ), + changed = false; </pre> Originally by r98080, these are outside the var statement, making them implied global. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
