Thanks for the comment, I mixed something up there. Will replace the vector
with a map and get rid of the std::sort call.
Diff comments:
>
> === modified file 'src/ui_fsmenu/options.cc'
> --- src/ui_fsmenu/options.cc 2017-09-11 16:59:41 +0000
> +++ src/ui_fsmenu/options.cc 2017-10-24 19:19:16 +0000
> @@ -432,7 +421,8 @@
> language_dropdown_.add(_("Try system language"), "", nullptr,
> current_locale == "");
> language_dropdown_.add("English", "en", nullptr, current_locale ==
> "en");
>
> - // Add translation directories to the list
> + // Add translation directories to the list. We are using a container
> that will support std::sort
> + // and that will avoid any eventual hash collisions on the sortname.
OK, I will go for a Map then and reimplement this. I've had my head stuck in
Java at my other job, so I'm used to maps being HashMaps now.
> std::vector<LanguageEntry> entries;
> std::string selected_locale;
>
--
https://code.launchpad.net/~widelands-dev/widelands/translation_stats/+merge/332029
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/translation_stats.
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
