Review: Approve lgtm, but I do not think that the productivity still drops fast now, does it? I do not think that is necessary a really bad problem, I think consistency is more important.
Diff comments: > === modified file 'tribes/atlanteans/quarry/conf' > --- tribes/atlanteans/quarry/conf 2014-08-02 19:55:23 +0000 > +++ tribes/atlanteans/quarry/conf 2015-03-30 18:56:08 +0000 > @@ -16,13 +16,19 @@ > stonecutter=1 > > [programs] > +# TRANSLATORS: "Completed/Skipped/Did not start quarrying stone because ... > +mine_stone=_quarrying stone > # TRANSLATORS: "Completed/Skipped/Did not start working because ... > work=_working > > -[work] > +[mine_stone] > worker=cut_stone # This order is on purpose so that the productivity > sleep=25000 # drops fast once all stones are gone. > > +[work] > +call=mine_stone > +return=skipped > + > [out_of_resource_notification] > title=_Out of Rocks > message=_The stonecutter working at this quarry can’t find any rocks in his > working radius. > > === modified file 'tribes/barbarians/quarry/conf' > --- tribes/barbarians/quarry/conf 2015-02-12 19:46:19 +0000 > +++ tribes/barbarians/quarry/conf 2015-03-30 18:56:08 +0000 > @@ -15,12 +15,18 @@ > stonemason=1 > > [programs] > +# TRANSLATORS: "Completed/Skipped/Did not start quarrying stone because ... > +mine_stone=_quarrying stone > # TRANSLATORS: "Completed/Skipped/Did not start working because ... > work=_working > > +[mine_stone] > +worker=cut # This order is on purpose so that the productivity the comment is no longer correct, is it? With the sleep in there the productivity will not drop fast anymore. > +sleep=25000 # drops fast once all stones are gone. > + > [work] > -worker=cut # This order is on purpose so that the productivity > -sleep=25000 # drops fast once all stones are gone. > +call=mine_stone > +return=skipped > > [out_of_resource_notification] > title=_Out of Rocks > -- https://code.launchpad.net/~widelands-dev/widelands/quarry_tweaks/+merge/254632 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/quarry_tweaks. _______________________________________________ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
