The problem is with the test suite. I can't track it down, so it probably lies 
with the binaries somewhere. I decided to allow lower packet versions in some 
places to keep the tests working, and there was no change in the packet 
content, just the packet number. I don't know how to fix the binaries. However, 
some tests now fail anyway due to wrong packet version numbers, so we will have 
to fix this in any case.

With my changes, I have increased the following packet numbers:

MapPlayerNamesAndTribesPacket: 1 -> 2
MapBuildingPacket: 3 -> 4
GamePlayerInfoPacket: 15 -> 16

I agree that we can get rid of the unused variable in GameClassPacket, but I'd 
prefer to sort out the problems with the test suite first, because we will need 
to increase the packet number.
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1291904/+merge/237128
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/bug-1291904.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to