Review: Needs Fixing
Just a nit: Please change:
if (not msgs . back() . sender . empty())
116 + // Alert me!
117 + play_new_chat_message();
to
if (!msgs.back().sender.empty()) {
// Alert me!
play_new_chat_message();
}
and I do not understand the comment that is directly above this if statement -
can you rephrase it somehow?
Otherwise lgtm. Feel free to merge yourself.
--
https://code.launchpad.net/~widelands-dev/widelands/feature-loudylobby/+merge/207819
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/feature-loudylobby.
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
