Overriding (Web)Page.configureResponse() is not that easy. The XmlPage in examples extends WebPage, not Page class. When you override, you have to call super class and you have to know what the superclass does (for instance not add the XML prologue twice). This is in my opinion dangerous and may not work in future version of Wicket. And I see no reason why XML pages should be served without XML prologue. The stripping is just hack for Internet Explorer, so for XML pages I have to hack the hack.
Jan "Juergen Donnerstag" <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > I'm not sure I understand what the RFE suggests or requests. I > understand your want to server HTML file (*.html) without xml > declaration and XML (*.xml) with xml decls. Like XmlPage.java in the > examples for the XML file you need to subclass Page.getMarkupType() to > return "xml" because that is what Wicket assumes to be the file > extension. Any ouy may as well subclass Page.configureResponse() to no > remove the xml decl. And voila, from that point on you can use WebPage > as base class for HTML pages and your XmlPage as base class for XML > pages > > Isn't that the solution? What else are you asking for? > > Juergen > > On 6/3/06, jan_bar <[EMAIL PROTECTED]> wrote: > > RFE 1499927. > > > > I already fix that with XmlPage.configureResponse(). > > > > Jan > > > > "Juergen Donnerstag" <[EMAIL PROTECTED]> wrote in message > > news:[EMAIL PROTECTED] > > > You could create your own BasePage for all Xml and HTML Pages and > > > subclass configureResponse. I'm not especially in favor of such > > > if(condition). They'll always be subject to discussions. > > > > > > Juergen > > > > > > On 6/2/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > > > > Could you please submit a feature request for that? > > > > > > > > Eelco > > > > > > > > On 6/2/06, jan_bar <[EMAIL PROTECTED]> wrote: > > > > > Hi, > > > > > > > > > > I am facing unpleasant troubles with setStripXmlDeclarationFromOutput. > > My > > > > > application needs to output HTML pages with stripped XML prologue, but > > at > > > > > the same time I have to serve XML files *with* the XML prologue. The > > > > > settings like StripXmlDeclarationFromOutput or StripWicketTags (and > > other) > > > > > or only application wide. > > > > > > > > > > Maybe, when Page.configureResponse() sees getMarkupType()=="xml", it > > should > > > > > not strip XML prologue even if StripXmlDeclarationFromOutput is set? > > > > > > > > > > Thanks for your support, Jan > > > > > > > > > > > > _______________________________________________ > > Wicket-user mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > _______________________________________________ Wicket-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-user
