I'm +1 for making it public (final). Eelco
On 9/5/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > currently form.findsubmittingbutton() is protected final - anyone against > making it public final? > > -Igor > > > On 9/5/06, Jaime De La Jara < [EMAIL PROTECTED]> wrote: > > > > giving it a second thought, the afterComponentCall approach seems good, > however to make it simpler the findSubmitting Button should be public so one > shouldn't have to make a new Form class just to call that method. I noticed > that the Feature Request #1476905 asks just that unfortunely is open. > > Thanks, > > > > Jaime. > > > > > > Jaime De La Jara < [EMAIL PROTECTED]> wrote: > > > > > > you're right, I browsed the source code of Form and Button and it's just > like that. The findSubmittingButton method is protected and final so > unfortunely It's of no use in this case. I guess that I'll check another way > to tackle this thing, maybe the simplest is to subclass a couple of class > MyButton and MyLink and have the subclasses call the superclass event > handler first. Thanks a lot again, > > > > Jaime. > > > > Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > yes because the event is raised on the form not the button, thats how http > works. the form then forwards the onsubmit to the button. seee > findSubmittingButton() in the form, too bad its not public otherwise you > couldve used it directly. > > > > -Igor > > > > > > > > On 9/5/06, Jaime De La Jara < [EMAIL PROTECTED]> wrote: > > > > > > I've just added the afterCallComponent to my base page and put some > println to see what Component and Listener it was receiving, and when I > click a submit button the component that gets called it's the form > containing it, I think I misunderstood the method's behaviour since I was > expecting that every call to a page component would cause this method to be > called. In this case I can't determine which button was clicked. Maybe what > I'm looking is too cumbersome, and should evaluate using AOP which in this > case I was trying to avoid, I haven't taken a look at Eelco proposal of > modifying the RequestCycleProcessor, first I'll try to understand it better. > > > > > > > > > Jaime. > > > > > > Igor Vaynberg <[EMAIL PROTECTED] > wrote: > > > > > > > > > but you can do this yourself by implementing callbacks to these > pluggable things in your basepage afterCallComponent. > > > > > > -Igor > > > > > > > > > > > > On 9/5/06, Jaime De La Jara < [EMAIL PROTECTED]> wrote: > > > > > > > > You're right the page method afterCallComponent could be used, just I > was looking for something like a superclass hook method that could be called > by the framework after some processing occurred (in my case after a submit). > > > > In the case for the generic callback I was thinking of something that > could be plugged in, instead of having a pair of methods for each step > (onBefore../after...), > > > > I'm not sure if it makes sense, maybe an interface callback approach > could also be useful. > > > > > > > > > > > > Jaime. > > > > > > > > > > > > Igor Vaynberg < [EMAIL PROTECTED] > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The page hook could be of useful for a submit button but maybe not > for a link. > > > > > > > > > > > > how do you figure? > > > > > > > > > > > > > > > > > > Perhaps, I'm not sure, but a generic callback mechanism could be > added to the Component class, so pre and post processor could be added for > the event listener methods (onSubmit(), onClick(), etc). > > > > > > > > > > > > we already have them and they have all been listed in this thread. i > dont think we need more, in fact i think we already have too many. > > > > > > > > -Igor > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > > > > > Using Tomcat but need to do more? Need to support web services, > security? > > > > Get stuff done quickly with pre-integrated technology to make your job > easier > > > > Download IBM WebSphere Application Server v.1.0.1 based on Apache > Geronimo > > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642_______________________________________________ > > > > Wicket-user mailing list > > > > Wicket-user@lists.sourceforge.net > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > > > > > > > > > > ________________________________ > Talk is cheap. Use Yahoo! Messenger to make PC-to-Phone calls. Great rates > starting at 1¢/min. > > > > > > > > > ------------------------------------------------------------------------- > > > > Using Tomcat but need to do more? Need to support web services, > security? > > > > Get stuff done quickly with pre-integrated technology to make your job > easier > > > > Download IBM WebSphere Application Server v.1.0.1 based on Apache > Geronimo > > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > > > > > _______________________________________________ > > > > Wicket-user mailing list > > > > Wicket-user@lists.sourceforge.net > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > > > > > Using Tomcat but need to do more? Need to support web services, > security? > > > Get stuff done quickly with pre-integrated technology to make your job > easier > > > Download IBM WebSphere Application Server v.1.0.1 based on Apache > Geronimo > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642_______________________________________________ > > > Wicket-user mailing list > > > Wicket-user@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > > > > > ________________________________ > Talk is cheap. Use Yahoo! Messenger to make PC-to-Phone calls. Great rates > starting at 1¢/min. > > > > > > > ------------------------------------------------------------------------- > > > Using Tomcat but need to do more? Need to support web services, > security? > > > Get stuff done quickly with pre-integrated technology to make your job > easier > > > Download IBM WebSphere Application Server v.1.0.1 based on Apache > Geronimo > > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > > > _______________________________________________ > > > Wicket-user mailing list > > > Wicket-user@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > > > > ------------------------------------------------------------------------- > > Using Tomcat but need to do more? Need to support web services, security? > > Get stuff done quickly with pre-integrated technology to make your job > easier > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642_______________________________________________ > > Wicket-user mailing list > > Wicket-user@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > ________________________________ > How low will we go? Check out Yahoo! Messenger's low PC-to-Phone call > rates.------------------------------------------------------------------------- > > > > Using Tomcat but need to do more? Need to support web services, security? > > Get stuff done quickly with pre-integrated technology to make your job > easier > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642_______________________________________________ > > Wicket-user mailing list > > Wicket-user@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > > ________________________________ > Yahoo! Messenger with Voice. Make PC-to-Phone Calls to the US (and 30+ > countries) for 2¢/min or less. > > > > > > > ------------------------------------------------------------------------- > > Using Tomcat but need to do more? Need to support web services, security? > > Get stuff done quickly with pre-integrated technology to make your job > easier > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > > > _______________________________________________ > > Wicket-user mailing list > > Wicket-user@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job > easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > _______________________________________________ > Wicket-develop mailing list > Wicket-develop@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
