Bugs item #1359704, was opened at 2005-11-18 10:33
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1359704&group_id=119783
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Marco van de haar (marcovandehaar)
Assigned to: Nobody/Anonymous (nobody)
Summary: current FeedbackPanel makes getFeedbackMessageFilter useless
Initial Comment:
The javadoc for getFeedbackMessageFilter() in
FeedbackPanel states that subclasses can use this
method to return their custom filter. The current
implementation of FeedbackPanel however calls:
new
MessageListView("messages")->setModel(newFeedbackMessagesModel())->return
new FeedbackMessagesModel(getFeedbackMessageFilter());
which is all being called in FeedbackPanel's
constructor. This means that whatever filter you supply
in your subclass, it will never be used. As the super()
is always called first in the subclass contructor.
A possible solution I think would be to add a
constructor to FeedBackPanel which had a filter
parameter. Then this constructor would be able to set
the right filter before calling
getFeedbackMessageFilter ().
/**
* @see wicket.Component#Component(String)
*/
public FeedbackPanel(final String id,
IFeedbackMessageFilter filter)
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1359704&group_id=119783
-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc. Get Certified Today
Register for a JBoss Training Course. Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
