yeah, i could see sticking with it too. it's quite a lot of work for not much payoff. i guess i'd like to change my vote to 0.
Eelco Hillenius wrote:
I don't have a *very* strong opinion about this, and allways used interfaces without the 'I' myself. But... now that I've used it with Wicket/ Eclipse for some time, I actually begun to like it. I like the fact that the Ixx is instantly regconizable as an interface, and that, if I am looking for an interface in Wicket I can just start typing an I.
In the case of models, I think IModel and Model are better than Model and DefaultModel (where DefaultXxx is the best naming to my taste; SerializableModel really doesn't say much more imo).
DefaultButtonImageResource says something because it's a default look that is created by the DefaultButtonImageFactory, which is actually installed by default. so Default means something.
i hate the idea of renaming Model to DefaultModel. because the model is not default. it's just named that way because of a lack of anything specific to call it. which brings us back to IXxx again... if we're going to use a meaningless naming convention, i'd prefer IXxx i guess...
I'd like to see more votes on this. My vote is -1/2. If this was the start of the project, it might have been +/- 0, but as we're trying to get out rc1 sometime soon (finally!), I don't see the need for more renaming discussions (besides the resources then). It's just not such a big deal IMO.
And as a last remark. I think Eclipse is one of the best examples of great software engineering of the last years. They are using the IXxx, so the argument that others don't (Sun/ new Tapestry) is not very strong.
So, others (non-developers as well?), pls vote?
Eelco
Jonathan Locke wrote:
i personally hate "Impl". it's exactly as meaningless as the IInterfaceName pattern. it's just a bunch of letters to let you know something /isn't/ an interface. all you've done with this pattern is switch the meaningless naming pattern around. and if you really did want to say "Impl", you should definitely say FooImplementation.
just because sun does something doesn't mean it is a best practice!
i'd like to try to avoid words like Default, Implementation, Context etc., which have essentially no meaning in most cases. what we ought to do is pick names that describe the /actual meaning/ of the concrete implementation! gee imagine that! for example, i think SerializableModel is a heck of a lot better as a name than "DefaultModel" because the Default in DefaultModel adds zero meaning for the user. what about this model makes it a default? is it going to be automatically instantiated for me as a default or something? i don't think so! it's a bad name because it ought to be just called Model... which is why i went for Model and IModel. if you're going to have meaningless names, make it short is what i thouhg.... anyway, if we're getting rid of the IInterfaceName pattern, i think SerializableModel at least has the potential to convey that the model wraps a Serializable object. if that's not quite right, we can surely find something better. even ObjectModel or NonDetachableModel is better than "DefaultModel". what does that mean?
Gili wrote:
I second that motion. +1 for removing this. Sun seems to use:
Interface: Foo Abstract: AbstractFoo Concrete: DefaultFoo
I believe the term "impl" seems to be mostly reserved for protected methods you inherit.
Gili
Martijn Dashorst wrote:
I know there is some personal preference concerning the IFoo method for naming interfaces. So I'd like to have some vote for keeping this naming convention, or dropping it.
I personally think that this stinks like a Hungarian notation and would like to get rid of it throughout the framework. It doesn't communicate intent: what is an IModel -> Model. If we have a class implementing the interface, and it provides a default and is not abstract, it could be named DefaultFoo or StandardFoo, or perhaps FooImpl. If it is abstract, it should be AbstractFoo, BaseFoo or FooBase.
Even Tapestry is renaming all interfaces to go without the I-prefix for the 4.0 release. I think we should not make the mistake Tapestry did: going live with the I-notation.
Martijn
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- This SF.net email is sponsored by Demarc: A global provider of Threat Management Solutions. Download our HomeAdmin security software for free today! http://www.demarc.com/info/Sentarus/hamr30 _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
------------------------------------------------------- This SF.net email is sponsored by Demarc: A global provider of Threat Management Solutions. Download our HomeAdmin security software for free today! http://www.demarc.com/info/Sentarus/hamr30 _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
