Now that I look at the actual code, my approach doesn't always work!  It
will not preserve comments at the root level. For example:

# This is a comment
[SectionA]
  # Comment on option1
  option1 = foo
  option2 = bar  # Inline comment about option2

The highlighted comment would not get preserved. The others would.

Fixed in commit 98eef9b
<https://github.com/weewx/weewx/commit/98eef9be0f9dddeb942847296ebe592f99051ec3>


On Wed, Dec 23, 2020 at 4:04 PM vince <vinceska...@gmail.com> wrote:

> On Wednesday, December 23, 2020 at 2:48:37 PM UTC-8 Tom Keffer wrote:
>
>> I guess I'm not understanding this. If you create a config section for
>> the installer, it will be faithfully reproduced as it gets injected into
>> weewx.conf, including any comments.
>>
>> As an example, take a look at install.py
>> <https://github.com/tkeffer/weewx-nmea-xdr/blob/master/install.py> for
>> weewx-nmea-xdr <https://github.com/tkeffer/weewx-nmea-xdr>.
>>
>>
> Perfect.
> Exactly what I was hoping to do.
>
> Neither Belchertown (here
> <https://github.com/poblabs/weewx-belchertown/blob/master/install.py>)
> nor weewx-mqtt (here
> <https://github.com/matthewwall/weewx-mqtt/blob/master/install.py>) do it
> that way.
> Your way is way slicker.
>
>
>> Or, am I missing something?
>>
>>
> Not in the least.
>
> Thanks a bunch !
>
> --
> You received this message because you are subscribed to the Google Groups
> "weewx-user" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to weewx-user+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/weewx-user/7abfafed-bdbe-42a3-a41d-22e5ffcfffddn%40googlegroups.com
> <https://groups.google.com/d/msgid/weewx-user/7abfafed-bdbe-42a3-a41d-22e5ffcfffddn%40googlegroups.com?utm_medium=email&utm_source=footer>
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"weewx-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to weewx-user+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/weewx-user/CAPq0zECxPuLRLfURYynuwgyasPCD1vDf%3DaCG2fg8vfqmF59AVw%40mail.gmail.com.

Reply via email to