Title: [198688] trunk/Source/WebInspectorUI
- Revision
- 198688
- Author
- [email protected]
- Date
- 2016-03-25 13:45:35 -0700 (Fri, 25 Mar 2016)
Log Message
Unreviewed, rolling out r198619.
https://bugs.webkit.org/show_bug.cgi?id=155902
Switching to Console tab sometimes results in blank tab.
(Requested by JoePeck on #webkit).
Reverted changeset:
"Web Inspector: Large repaints while typing in the console
tab"
https://bugs.webkit.org/show_bug.cgi?id=155627
http://trac.webkit.org/changeset/198619
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (198687 => 198688)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-03-25 20:37:49 UTC (rev 198687)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-03-25 20:45:35 UTC (rev 198688)
@@ -1,3 +1,18 @@
+2016-03-25 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r198619.
+ https://bugs.webkit.org/show_bug.cgi?id=155902
+
+ Switching to Console tab sometimes results in blank tab.
+ (Requested by JoePeck on #webkit).
+
+ Reverted changeset:
+
+ "Web Inspector: Large repaints while typing in the console
+ tab"
+ https://bugs.webkit.org/show_bug.cgi?id=155627
+ http://trac.webkit.org/changeset/198619
+
2016-03-25 Matt Baker <[email protected]>
Web Inspector: Scrolling/selection is broken in Quick Open dialog resource tree
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (198687 => 198688)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2016-03-25 20:37:49 UTC (rev 198687)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2016-03-25 20:45:35 UTC (rev 198688)
@@ -226,7 +226,6 @@
this.tabBar = new WebInspector.TabBar(document.getElementById("tab-bar"));
this.tabBar.addEventListener(WebInspector.TabBar.Event.NewTabItemClicked, this._newTabItemClicked, this);
this.tabBar.addEventListener(WebInspector.TabBar.Event.OpenDefaultTab, this._openDefaultTab, this);
- this.tabBar.addEventListener(WebInspector.TabBar.Event.TabBarItemSelected, this._tabBarItemSelected, this);
this._contentElement = document.getElementById("content");
this._contentElement.setAttribute("role", "main");
@@ -541,18 +540,6 @@
this.showNewTabTab();
};
-WebInspector._tabBarItemSelected = function(event)
-{
- let {previouslySelectedTabIdentifier, selectedTabIdentifier} = event.data;
- const classNamePrefix = "selected-tab-";
-
- if (previouslySelectedTabIdentifier)
- document.body.classList.remove(classNamePrefix + previouslySelectedTabIdentifier);
-
- console.assert(selectedTabIdentifier);
- document.body.classList.add(classNamePrefix + selectedTabIdentifier);
-};
-
WebInspector._tryToRestorePendingTabs = function()
{
let stillPendingOpenTabs = [];
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (198687 => 198688)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2016-03-25 20:37:49 UTC (rev 198687)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css 2016-03-25 20:45:35 UTC (rev 198688)
@@ -23,15 +23,6 @@
* THE POSSIBILITY OF SUCH DAMAGE.
*/
-body.selected-tab-console #content {
- /* FIXME: This shouldn't be necessary once https://webkit.org/b/145324 is resolved. */
- position: absolute;
- top: 0;
- bottom: 0;
- left: 0;
- right: 0;
-}
-
.log-scope-bar > li.unread::before {
content: '';
display: inline-block;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js (198687 => 198688)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js 2016-03-25 20:37:49 UTC (rev 198687)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TabBar.js 2016-03-25 20:45:35 UTC (rev 198688)
@@ -363,23 +363,15 @@
if (this._selectedTabBarItem === tabBarItem)
return;
- let previouslySelectedTabIdentifier = "";
-
- if (this._selectedTabBarItem) {
+ if (this._selectedTabBarItem)
this._selectedTabBarItem.selected = false;
- previouslySelectedTabIdentifier = this._selectedTabBarItem.representedObject.identifier;
- }
this._selectedTabBarItem = tabBarItem || null;
- let selectedTabIdentifier = "";
-
- if (this._selectedTabBarItem) {
+ if (this._selectedTabBarItem)
this._selectedTabBarItem.selected = true;
- selectedTabIdentifier = this._selectedTabBarItem.representedObject.identifier;
- }
- this.dispatchEventToListeners(WebInspector.TabBar.Event.TabBarItemSelected, {previouslySelectedTabIdentifier, selectedTabIdentifier});
+ this.dispatchEventToListeners(WebInspector.TabBar.Event.TabBarItemSelected);
}
get tabBarItems()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
