Title: [198378] trunk/Source/WebKit2
- Revision
- 198378
- Author
- [email protected]
- Date
- 2016-03-17 23:12:42 -0700 (Thu, 17 Mar 2016)
Log Message
SpeculativeLoad needs to continue NetworkLoad when it receives a redirect response
https://bugs.webkit.org/show_bug.cgi?id=155612
Reviewed by Andy Estes.
* NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::willSendRedirectedRequest):
Call continueWillSendRequest. Otherwise, we will hang a thread in the NetworkProcess
if we are using ResourceHandle or we will not call the willPerformHTTPRedirection
completion handler if we are using NetworkSession. This will cause us to stop loading
from the server after the maximum number of connections is reached.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (198377 => 198378)
--- trunk/Source/WebKit2/ChangeLog 2016-03-18 04:45:46 UTC (rev 198377)
+++ trunk/Source/WebKit2/ChangeLog 2016-03-18 06:12:42 UTC (rev 198378)
@@ -1,3 +1,17 @@
+2016-03-17 Alex Christensen <[email protected]>
+
+ SpeculativeLoad needs to continue NetworkLoad when it receives a redirect response
+ https://bugs.webkit.org/show_bug.cgi?id=155612
+
+ Reviewed by Andy Estes.
+
+ * NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
+ (WebKit::NetworkCache::SpeculativeLoad::willSendRedirectedRequest):
+ Call continueWillSendRequest. Otherwise, we will hang a thread in the NetworkProcess
+ if we are using ResourceHandle or we will not call the willPerformHTTPRedirection
+ completion handler if we are using NetworkSession. This will cause us to stop loading
+ from the server after the maximum number of connections is reached.
+
2016-03-17 Tim Horton <[email protected]>
Find-in-page indicator in Mail viewer is the wrong scale and cut off
Modified: trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp (198377 => 198378)
--- trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp 2016-03-18 04:45:46 UTC (rev 198377)
+++ trunk/Source/WebKit2/NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp 2016-03-18 06:12:42 UTC (rev 198378)
@@ -63,9 +63,10 @@
ASSERT(!m_networkLoad);
}
-void SpeculativeLoad::willSendRedirectedRequest(const ResourceRequest& request, const ResourceRequest& redirectRequest, const ResourceResponse& redirectResponse)
+void SpeculativeLoad::willSendRedirectedRequest(const ResourceRequest&, const ResourceRequest& redirectRequest, const ResourceResponse& redirectResponse)
{
updateRedirectChainStatus(m_redirectChainCacheStatus, redirectResponse);
+ m_networkLoad->continueWillSendRequest(redirectRequest);
}
auto SpeculativeLoad::didReceiveResponse(const ResourceResponse& receivedResponse) -> ShouldContinueDidReceiveResponse
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
