Title: [198049] trunk/Source/WebKit2
- Revision
- 198049
- Author
- [email protected]
- Date
- 2016-03-11 14:50:21 -0800 (Fri, 11 Mar 2016)
Log Message
Use only selected text for Look up.
https://bugs.webkit.org/show_bug.cgi?id=155380
Reviewed by Tim Horton.
The corresponding piece that uses the extended context for Look up
is not ready yet. For the moment default to retrieving the selected text.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _lookup:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (198048 => 198049)
--- trunk/Source/WebKit2/ChangeLog 2016-03-11 22:49:00 UTC (rev 198048)
+++ trunk/Source/WebKit2/ChangeLog 2016-03-11 22:50:21 UTC (rev 198049)
@@ -1,3 +1,16 @@
+2016-03-11 Enrica Casucci <[email protected]>
+
+ Use only selected text for Look up.
+ https://bugs.webkit.org/show_bug.cgi?id=155380
+
+ Reviewed by Tim Horton.
+
+ The corresponding piece that uses the extended context for Look up
+ is not ready yet. For the moment default to retrieving the selected text.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _lookup:]):
+
2016-03-11 Chelsea Pugh <[email protected]>
[iOS] Allow clients to specify text suggestions to be used for a form input session
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (198048 => 198049)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2016-03-11 22:49:00 UTC (rev 198048)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2016-03-11 22:50:21 UTC (rev 198049)
@@ -1610,10 +1610,10 @@
return (_page->editorState().isContentRichlyEditable) ? richTypes : plainTextTypes;
}
-- (void)_lookup:(CGPoint)point
+- (void)_lookup:(id)sender
{
RetainPtr<WKContentView> view = self;
- _page->getLookupContextAtPoint(WebCore::IntPoint(point), [view](const String& string, CallbackBase::Error error) {
+ _page->getSelectionOrContentsAsString([view](const String& string, CallbackBase::Error error) {
if (error != CallbackBase::Error::None)
return;
if (!string)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
