Title: [198044] trunk/Source/WebCore
- Revision
- 198044
- Author
- [email protected]
- Date
- 2016-03-11 13:47:19 -0800 (Fri, 11 Mar 2016)
Log Message
Fix typo in StyleTreeResolver.cpp
https://bugs.webkit.org/show_bug.cgi?id=139946
Patch by Maksim Kisilev <[email protected]> on 2016-03-10
Reviewed by Andy Estes.
The constructor for CheckForVisibilityChangeOnRecalcStyle was improperly comparing the
result of WKContentChange() (which is not a function) to WKContentVisibilityChange. I
believe the above cast would implicitly resolve to WKContentNoChange in all cases,
whether a visibility change had been observed or not.
This patch corrects this problem. I would expect that this might affect some content
visibility change behavior, but I'm not sure what the appropriate test case would be
since this was apparently found through code inspection.
* style/StyleTreeResolver.cpp:
(WebCore::Style::CheckForVisibilityChangeOnRecalcStyle::CheckForVisibilityChangeOnRecalcStyle):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (198043 => 198044)
--- trunk/Source/WebCore/ChangeLog 2016-03-11 21:46:54 UTC (rev 198043)
+++ trunk/Source/WebCore/ChangeLog 2016-03-11 21:47:19 UTC (rev 198044)
@@ -1,3 +1,22 @@
+2016-03-10 Maksim Kisilev <[email protected]>
+
+ Fix typo in StyleTreeResolver.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=139946
+
+ Reviewed by Andy Estes.
+
+ The constructor for CheckForVisibilityChangeOnRecalcStyle was improperly comparing the
+ result of WKContentChange() (which is not a function) to WKContentVisibilityChange. I
+ believe the above cast would implicitly resolve to WKContentNoChange in all cases,
+ whether a visibility change had been observed or not.
+
+ This patch corrects this problem. I would expect that this might affect some content
+ visibility change behavior, but I'm not sure what the appropriate test case would be
+ since this was apparently found through code inspection.
+
+ * style/StyleTreeResolver.cpp:
+ (WebCore::Style::CheckForVisibilityChangeOnRecalcStyle::CheckForVisibilityChangeOnRecalcStyle):
+
2016-03-11 Chris Dumez <[email protected]>
iOS-sim debug: WebCoreNSURLSessionTest.BasicOperation and WebCoreNSURLSessionTest.InvalidateEmpty asserting
Modified: trunk/Source/WebCore/style/StyleTreeResolver.cpp (198043 => 198044)
--- trunk/Source/WebCore/style/StyleTreeResolver.cpp 2016-03-11 21:46:54 UTC (rev 198043)
+++ trunk/Source/WebCore/style/StyleTreeResolver.cpp 2016-03-11 21:47:19 UTC (rev 198044)
@@ -790,7 +790,7 @@
: m_element(element)
, m_previousDisplay(currentStyle ? currentStyle->display() : NONE)
, m_previousVisibility(currentStyle ? currentStyle->visibility() : HIDDEN)
- , m_previousImplicitVisibility(WKObservingContentChanges() && WKContentChange() != WKContentVisibilityChange ? elementImplicitVisibility(element) : VISIBLE)
+ , m_previousImplicitVisibility(WKObservingContentChanges() && WKObservedContentChange() != WKContentVisibilityChange ? elementImplicitVisibility(element) : VISIBLE)
{
}
~CheckForVisibilityChangeOnRecalcStyle()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
