Title: [195731] trunk
Revision
195731
Author
[email protected]
Date
2016-01-27 22:23:57 -0800 (Wed, 27 Jan 2016)

Log Message

Expose ValidityState on the global Window object
https://bugs.webkit.org/show_bug.cgi?id=153582

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaseline W3C html test now that more checks are passing.

* web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Expose ValidityState on the global Window object:
https://html.spec.whatwg.org/#validitystate

Firefox and Chrome match the specification.

No new tests, already covered by existing tests.

* html/ValidityState.idl:

LayoutTests:

Rebaseline test now that ValidityState is exposed on the global Window
object.

* js/dom/global-constructors-attributes-expected.txt:
* platform/efl/js/dom/global-constructors-attributes-expected.txt:
* platform/gtk/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
* platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:
* platform/win/js/dom/global-constructors-attributes-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (195730 => 195731)


--- trunk/LayoutTests/ChangeLog	2016-01-28 06:00:37 UTC (rev 195730)
+++ trunk/LayoutTests/ChangeLog	2016-01-28 06:23:57 UTC (rev 195731)
@@ -1,5 +1,23 @@
 2016-01-27  Chris Dumez  <[email protected]>
 
+        Expose ValidityState on the global Window object
+        https://bugs.webkit.org/show_bug.cgi?id=153582
+
+        Reviewed by Antti Koivisto.
+
+        Rebaseline test now that ValidityState is exposed on the global Window
+        object.
+
+        * js/dom/global-constructors-attributes-expected.txt:
+        * platform/efl/js/dom/global-constructors-attributes-expected.txt:
+        * platform/gtk/js/dom/global-constructors-attributes-expected.txt:
+        * platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
+        * platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
+        * platform/mac/js/dom/global-constructors-attributes-expected.txt:
+        * platform/win/js/dom/global-constructors-attributes-expected.txt:
+
+2016-01-27  Chris Dumez  <[email protected]>
+
         Expose ApplicationCache on the global Window object
         https://bugs.webkit.org/show_bug.cgi?id=153578
 

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (195730 => 195731)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-01-28 06:00:37 UTC (rev 195730)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-01-28 06:23:57 UTC (rev 195731)
@@ -1,5 +1,16 @@
 2016-01-27  Chris Dumez  <[email protected]>
 
+        Expose ValidityState on the global Window object
+        https://bugs.webkit.org/show_bug.cgi?id=153582
+
+        Reviewed by Antti Koivisto.
+
+        Rebaseline W3C html test now that more checks are passing.
+
+        * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-01-27  Chris Dumez  <[email protected]>
+
         Expose ApplicationCache on the global Window object
         https://bugs.webkit.org/show_bug.cgi?id=153578
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (195730 => 195731)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-01-28 06:00:37 UTC (rev 195730)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt	2016-01-28 06:23:57 UTC (rev 195731)
@@ -3312,23 +3312,23 @@
 FAIL AutocompleteErrorEvent interface: existence and properties of interface prototype object assert_own_property: self does not have own property "AutocompleteErrorEvent" expected property "AutocompleteErrorEvent" missing
 FAIL AutocompleteErrorEvent interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "AutocompleteErrorEvent" expected property "AutocompleteErrorEvent" missing
 FAIL AutocompleteErrorEvent interface: attribute reason assert_own_property: self does not have own property "AutocompleteErrorEvent" expected property "AutocompleteErrorEvent" missing
-FAIL ValidityState interface: existence and properties of interface object assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface object length assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface object name assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface: existence and properties of interface prototype object assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface: existence and properties of interface prototype object's "constructor" property assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface: attribute valueMissing assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface: attribute typeMismatch assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface: attribute patternMismatch assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface: attribute tooLong assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface: attribute tooShort assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface: attribute rangeUnderflow assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface: attribute rangeOverflow assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface: attribute stepMismatch assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface: attribute badInput assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface: attribute customError assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState interface: attribute valid assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
-FAIL ValidityState must be primary interface of document.createElement("input").validity assert_own_property: self does not have own property "ValidityState" expected property "ValidityState" missing
+FAIL ValidityState interface: existence and properties of interface object assert_equals: class string of ValidityState expected "[object Function]" but got "[object ValidityStateConstructor]"
+PASS ValidityState interface object length 
+PASS ValidityState interface object name 
+PASS ValidityState interface: existence and properties of interface prototype object 
+FAIL ValidityState interface: existence and properties of interface prototype object's "constructor" property assert_true: ValidityState.prototype.constructor is not writable expected true got false
+FAIL ValidityState interface: attribute valueMissing assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ValidityState interface: attribute typeMismatch assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ValidityState interface: attribute patternMismatch assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ValidityState interface: attribute tooLong assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ValidityState interface: attribute tooShort assert_true: The prototype object must have a property "tooShort" expected true got false
+FAIL ValidityState interface: attribute rangeUnderflow assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ValidityState interface: attribute rangeOverflow assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ValidityState interface: attribute stepMismatch assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ValidityState interface: attribute badInput assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ValidityState interface: attribute customError assert_equals: getter must be Function expected "function" but got "undefined"
+FAIL ValidityState interface: attribute valid assert_equals: getter must be Function expected "function" but got "undefined"
+PASS ValidityState must be primary interface of document.createElement("input").validity 
 PASS Stringification of document.createElement("input").validity 
 PASS ValidityState interface: document.createElement("input").validity must inherit property "valueMissing" with the proper type (0) 
 PASS ValidityState interface: document.createElement("input").validity must inherit property "typeMismatch" with the proper type (1) 

Modified: trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt (195730 => 195731)


--- trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:00:37 UTC (rev 195730)
+++ trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:23:57 UTC (rev 195731)
@@ -1798,6 +1798,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'VTTCue').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTCue').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTCue').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').value is ValidityState
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'WaveShaperNode').value is WaveShaperNode
 PASS Object.getOwnPropertyDescriptor(global, 'WaveShaperNode').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'WaveShaperNode').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt (195730 => 195731)


--- trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:00:37 UTC (rev 195730)
+++ trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:23:57 UTC (rev 195731)
@@ -1888,6 +1888,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'VTTCue').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTCue').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTCue').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').value is ValidityState
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'VideoStreamTrack').value is VideoStreamTrack
 PASS Object.getOwnPropertyDescriptor(global, 'VideoStreamTrack').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'VideoStreamTrack').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt (195730 => 195731)


--- trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:00:37 UTC (rev 195730)
+++ trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:23:57 UTC (rev 195731)
@@ -1908,6 +1908,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'VTTCue').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTCue').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTCue').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').value is ValidityState
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'VideoStreamTrack').value is VideoStreamTrack
 PASS Object.getOwnPropertyDescriptor(global, 'VideoStreamTrack').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'VideoStreamTrack').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt (195730 => 195731)


--- trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:00:37 UTC (rev 195730)
+++ trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:23:57 UTC (rev 195731)
@@ -1923,6 +1923,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'VTTRegion').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTRegion').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTRegion').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').value is ValidityState
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'WaveShaperNode').value is WaveShaperNode
 PASS Object.getOwnPropertyDescriptor(global, 'WaveShaperNode').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'WaveShaperNode').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt (195730 => 195731)


--- trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:00:37 UTC (rev 195730)
+++ trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:23:57 UTC (rev 195731)
@@ -1898,6 +1898,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'VTTRegion').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTRegion').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTRegion').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').value is ValidityState
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'WaveShaperNode').value is WaveShaperNode
 PASS Object.getOwnPropertyDescriptor(global, 'WaveShaperNode').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'WaveShaperNode').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt (195730 => 195731)


--- trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:00:37 UTC (rev 195730)
+++ trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:23:57 UTC (rev 195731)
@@ -1923,6 +1923,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'VTTRegion').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTRegion').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTRegion').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').value is ValidityState
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'WaveShaperNode').value is WaveShaperNode
 PASS Object.getOwnPropertyDescriptor(global, 'WaveShaperNode').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'WaveShaperNode').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt (195730 => 195731)


--- trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:00:37 UTC (rev 195730)
+++ trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt	2016-01-28 06:23:57 UTC (rev 195731)
@@ -1723,6 +1723,11 @@
 PASS Object.getOwnPropertyDescriptor(global, 'VTTRegion').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTRegion').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'VTTRegion').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').value is ValidityState
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ValidityState').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'WebKitAnimationEvent').value is WebKitAnimationEvent
 PASS Object.getOwnPropertyDescriptor(global, 'WebKitAnimationEvent').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'WebKitAnimationEvent').hasOwnProperty('set') is false

Modified: trunk/Source/WebCore/ChangeLog (195730 => 195731)


--- trunk/Source/WebCore/ChangeLog	2016-01-28 06:00:37 UTC (rev 195730)
+++ trunk/Source/WebCore/ChangeLog	2016-01-28 06:23:57 UTC (rev 195731)
@@ -1,5 +1,21 @@
 2016-01-27  Chris Dumez  <[email protected]>
 
+        Expose ValidityState on the global Window object
+        https://bugs.webkit.org/show_bug.cgi?id=153582
+
+        Reviewed by Antti Koivisto.
+
+        Expose ValidityState on the global Window object:
+        https://html.spec.whatwg.org/#validitystate
+
+        Firefox and Chrome match the specification.
+
+        No new tests, already covered by existing tests.
+
+        * html/ValidityState.idl:
+
+2016-01-27  Chris Dumez  <[email protected]>
+
         Expose ApplicationCache on the global Window object
         https://bugs.webkit.org/show_bug.cgi?id=153578
 

Modified: trunk/Source/WebCore/html/ValidityState.idl (195730 => 195731)


--- trunk/Source/WebCore/html/ValidityState.idl	2016-01-28 06:00:37 UTC (rev 195730)
+++ trunk/Source/WebCore/html/ValidityState.idl	2016-01-28 06:23:57 UTC (rev 195731)
@@ -21,7 +21,6 @@
  */
 
 [
-    NoInterfaceObject,
     SkipVTableValidation
 ] interface ValidityState {
     readonly attribute boolean         valueMissing;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to