Diff
Modified: trunk/Source/WebKit2/ChangeLog (195557 => 195558)
--- trunk/Source/WebKit2/ChangeLog 2016-01-25 22:37:49 UTC (rev 195557)
+++ trunk/Source/WebKit2/ChangeLog 2016-01-25 23:08:03 UTC (rev 195558)
@@ -1,3 +1,18 @@
+2016-01-25 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r195543.
+ https://bugs.webkit.org/show_bug.cgi?id=153451
+
+ regressed performance of test bots by ~6% (Requested by dydz
+ on #webkit).
+
+ Reverted changeset:
+
+ "WebKitTestRunner: Credential cache is not cleared between
+ tests"
+ https://bugs.webkit.org/show_bug.cgi?id=153407
+ http://trac.webkit.org/changeset/195543
+
2016-01-25 Chris Dumez <[email protected]>
[WK2][NetworkCache] Enable speculative revalidation
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (195557 => 195558)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2016-01-25 22:37:49 UTC (rev 195557)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp 2016-01-25 23:08:03 UTC (rev 195558)
@@ -255,11 +255,6 @@
#endif
}
-void NetworkProcess::switchToNewTestingSession()
-{
- NetworkStorageSession::switchToNewTestingSession();
-}
-
void NetworkProcess::ensurePrivateBrowsingSession(SessionID sessionID)
{
RemoteNetworkingContext::ensurePrivateBrowsingSession(sessionID);
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h (195557 => 195558)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2016-01-25 22:37:49 UTC (rev 195557)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h 2016-01-25 23:08:03 UTC (rev 195558)
@@ -146,8 +146,6 @@
void deleteWebsiteData(WebCore::SessionID, uint64_t websiteDataTypes, std::chrono::system_clock::time_point modifiedSince, uint64_t callbackID);
void deleteWebsiteDataForOrigins(WebCore::SessionID, uint64_t websiteDataTypes, const Vector<WebCore::SecurityOriginData>& origins, const Vector<String>& cookieHostNames, uint64_t callbackID);
- void switchToNewTestingSession();
-
// FIXME: This should take a session ID so we can identify which disk cache to delete.
void clearDiskCache(std::chrono::system_clock::time_point modifiedSince, std::function<void ()> completionHandler);
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in (195557 => 195558)
--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in 2016-01-25 22:37:49 UTC (rev 195557)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.messages.in 2016-01-25 23:08:03 UTC (rev 195558)
@@ -32,8 +32,6 @@
UserPreferredLanguagesChanged(Vector<String> languages)
#endif
- SwitchToNewTestingSession()
-
EnsurePrivateBrowsingSession(WebCore::SessionID sessionID)
DestroyPrivateBrowsingSession(WebCore::SessionID sessionID)
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (195557 => 195558)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2016-01-25 22:37:49 UTC (rev 195557)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2016-01-25 23:08:03 UTC (rev 195558)
@@ -538,11 +538,6 @@
toImpl(context)->useTestingNetworkSession();
}
-void WKContextResetTestingNetworkSession(WKContextRef context)
-{
- toImpl(context)->resetTestingNetworkSession();
-}
-
WKDictionaryRef WKContextCopyPlugInAutoStartOriginHashes(WKContextRef contextRef)
{
return toAPI(toImpl(contextRef)->plugInAutoStartOriginHashes().leakRef());
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h (195557 => 195558)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h 2016-01-25 22:37:49 UTC (rev 195557)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContextPrivate.h 2016-01-25 23:08:03 UTC (rev 195558)
@@ -82,9 +82,6 @@
// Test only. Should be called before any secondary processes are started.
WK_EXPORT void WKContextUseTestingNetworkSession(WKContextRef context);
-// Test only. Should be called before running a test.
-WK_EXPORT void WKContextResetTestingNetworkSession(WKContextRef context);
-
typedef void (*WKContextInvalidMessageFunction)(WKStringRef messageName);
WK_EXPORT void WKContextSetInvalidMessageFunction(WKContextInvalidMessageFunction invalidMessageFunction);
Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp (195557 => 195558)
--- trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2016-01-25 22:37:49 UTC (rev 195557)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.cpp 2016-01-25 23:08:03 UTC (rev 195558)
@@ -1073,18 +1073,6 @@
m_shouldUseTestingNetworkSession = true;
}
-void WebProcessPool::resetTestingNetworkSession()
-{
- ASSERT(!m_processes.isEmpty());
- ASSERT(m_networkProcess);
-
- if (!m_shouldUseTestingNetworkSession || !m_networkProcess || m_processes.isEmpty())
- return;
-
- sendToAllProcesses(Messages::WebProcess::SwitchToNewTestingSession());
- m_networkProcess->send(Messages::NetworkProcess::SwitchToNewTestingSession(), 0);
-}
-
void WebProcessPool::allowSpecificHTTPSCertificateForHost(const WebCertificateInfo* certificate, const String& host)
{
if (m_networkProcess)
Modified: trunk/Source/WebKit2/UIProcess/WebProcessPool.h (195557 => 195558)
--- trunk/Source/WebKit2/UIProcess/WebProcessPool.h 2016-01-25 22:37:49 UTC (rev 195557)
+++ trunk/Source/WebKit2/UIProcess/WebProcessPool.h 2016-01-25 23:08:03 UTC (rev 195558)
@@ -239,7 +239,6 @@
void setCookieStorageDirectory(const String& dir) { m_overrideCookieStorageDirectory = dir; }
void useTestingNetworkSession();
- void resetTestingNetworkSession();
bool isUsingTestingNetworkSession() const { return m_shouldUseTestingNetworkSession; }
void allowSpecificHTTPSCertificateForHost(const WebCertificateInfo*, const String& host);
Modified: trunk/Source/WebKit2/WebProcess/WebProcess.cpp (195557 => 195558)
--- trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2016-01-25 22:37:49 UTC (rev 195557)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.cpp 2016-01-25 23:08:03 UTC (rev 195558)
@@ -498,11 +498,6 @@
}
}
-void WebProcess::switchToNewTestingSession()
-{
- NetworkStorageSession::switchToNewTestingSession();
-}
-
WebPage* WebProcess::focusedWebPage() const
{
for (auto& page : m_pageMap.values()) {
Modified: trunk/Source/WebKit2/WebProcess/WebProcess.h (195557 => 195558)
--- trunk/Source/WebKit2/WebProcess/WebProcess.h 2016-01-25 22:37:49 UTC (rev 195557)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.h 2016-01-25 23:08:03 UTC (rev 195558)
@@ -210,8 +210,6 @@
void initializeWebProcess(WebProcessCreationParameters&&);
void platformInitializeWebProcess(WebProcessCreationParameters&&);
- void switchToNewTestingSession();
-
void platformTerminate();
void registerURLSchemeAsEmptyDocument(const String&);
void registerURLSchemeAsSecure(const String&) const;
Modified: trunk/Source/WebKit2/WebProcess/WebProcess.messages.in (195557 => 195558)
--- trunk/Source/WebKit2/WebProcess/WebProcess.messages.in 2016-01-25 22:37:49 UTC (rev 195557)
+++ trunk/Source/WebKit2/WebProcess/WebProcess.messages.in 2016-01-25 23:08:03 UTC (rev 195558)
@@ -45,8 +45,6 @@
UserPreferredLanguagesChanged(Vector<String> languages)
FullKeyboardAccessModeChanged(bool fullKeyboardAccessEnabled)
- SwitchToNewTestingSession()
-
// Legacy private browsing session is per process. Individual pages or page groups may use the private session or the default one as appropriate.
EnsurePrivateBrowsingSession(WebCore::SessionID sessionID)
DestroyPrivateBrowsingSession(WebCore::SessionID sessionID)
Modified: trunk/Tools/ChangeLog (195557 => 195558)
--- trunk/Tools/ChangeLog 2016-01-25 22:37:49 UTC (rev 195557)
+++ trunk/Tools/ChangeLog 2016-01-25 23:08:03 UTC (rev 195558)
@@ -1,3 +1,18 @@
+2016-01-25 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r195543.
+ https://bugs.webkit.org/show_bug.cgi?id=153451
+
+ regressed performance of test bots by ~6% (Requested by dydz
+ on #webkit).
+
+ Reverted changeset:
+
+ "WebKitTestRunner: Credential cache is not cleared between
+ tests"
+ https://bugs.webkit.org/show_bug.cgi?id=153407
+ http://trac.webkit.org/changeset/195543
+
2016-01-25 Aakash Jain <[email protected]>
Failing to upload to flakiness dashboard should not be a hard error
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (195557 => 195558)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2016-01-25 22:37:49 UTC (rev 195557)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2016-01-25 23:08:03 UTC (rev 195558)
@@ -714,8 +714,6 @@
WKContextSetCacheModel(TestController::singleton().context(), kWKCacheModelDocumentBrowser);
- WKContextResetTestingNetworkSession(TestController::singleton().context());
-
// FIXME: This function should also ensure that there is only one page open.
// Reset the EventSender for each test.
