Title: [195473] trunk/Source/_javascript_Core
Revision
195473
Author
[email protected]
Date
2016-01-22 14:12:59 -0800 (Fri, 22 Jan 2016)

Log Message

op_profile_type 32-bit LLInt implementation has a bug
https://bugs.webkit.org/show_bug.cgi?id=153368

Reviewed by Michael Saboff.

r189293 changed which registers were used, specifically
using t5 instead of t4. That change forgot to replace
t4 with t5 in one specific instance.

* llint/LowLevelInterpreter32_64.asm:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (195472 => 195473)


--- trunk/Source/_javascript_Core/ChangeLog	2016-01-22 22:08:16 UTC (rev 195472)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-01-22 22:12:59 UTC (rev 195473)
@@ -1,3 +1,16 @@
+2016-01-22  Saam barati  <[email protected]>
+
+        op_profile_type 32-bit LLInt implementation has a bug
+        https://bugs.webkit.org/show_bug.cgi?id=153368
+
+        Reviewed by Michael Saboff.
+
+        r189293 changed which registers were used, specifically
+        using t5 instead of t4. That change forgot to replace
+        t4 with t5 in one specific instance.
+
+        * llint/LowLevelInterpreter32_64.asm:
+
 2016-01-22  Filip Pizlo  <[email protected]>
 
         B3 should reduce obvious forms of Shl(SShr)

Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (195472 => 195473)


--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2016-01-22 22:08:16 UTC (rev 195472)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2016-01-22 22:12:59 UTC (rev 195473)
@@ -2401,7 +2401,7 @@
     loadisFromInstruction(1, t2)
     loadConstantOrVariable(t2, t5, t0)
 
-    bieq t4, EmptyValueTag, .opProfileTypeDone
+    bieq t5, EmptyValueTag, .opProfileTypeDone
 
     # t2 is holding the pointer to the current log entry.
     loadp TypeProfilerLog::m_currentLogEntryPtr[t1], t2
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to