Title: [190514] trunk/Source/WebCore
- Revision
- 190514
- Author
- [email protected]
- Date
- 2015-10-02 12:36:32 -0700 (Fri, 02 Oct 2015)
Log Message
ASSERTION FAILED: param >= 0 in AnimationBase::updateStateMachine()
https://bugs.webkit.org/show_bug.cgi?id=149737
rdar://problem/19017465
Reviewed by Dean Jackson.
CoreAnimation can give us an animation beginTime that is slightly into the future,
which results in 'param' here being < 0, so relax the assertion slightly.
Fixes lots of assertions running iOS WK2 layout tests.
* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::updateStateMachine):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (190513 => 190514)
--- trunk/Source/WebCore/ChangeLog 2015-10-02 18:33:49 UTC (rev 190513)
+++ trunk/Source/WebCore/ChangeLog 2015-10-02 19:36:32 UTC (rev 190514)
@@ -1,3 +1,19 @@
+2015-10-02 Simon Fraser <[email protected]>
+
+ ASSERTION FAILED: param >= 0 in AnimationBase::updateStateMachine()
+ https://bugs.webkit.org/show_bug.cgi?id=149737
+ rdar://problem/19017465
+
+ Reviewed by Dean Jackson.
+
+ CoreAnimation can give us an animation beginTime that is slightly into the future,
+ which results in 'param' here being < 0, so relax the assertion slightly.
+
+ Fixes lots of assertions running iOS WK2 layout tests.
+
+ * page/animation/AnimationBase.cpp:
+ (WebCore::AnimationBase::updateStateMachine):
+
2015-10-02 Per Arne Vollan <[email protected]>
[WinCairo] Fix linker warnings.
Modified: trunk/Source/WebCore/page/animation/AnimationBase.cpp (190513 => 190514)
--- trunk/Source/WebCore/page/animation/AnimationBase.cpp 2015-10-02 18:33:49 UTC (rev 190513)
+++ trunk/Source/WebCore/page/animation/AnimationBase.cpp 2015-10-02 19:36:32 UTC (rev 190514)
@@ -286,7 +286,7 @@
ASSERT(input == AnimationStateInput::StartTimeSet || input == AnimationStateInput::PlayStatePaused);
if (input == AnimationStateInput::StartTimeSet) {
- ASSERT(param >= 0);
+ ASSERT(param > -0.001); // Sometimes Core Animation gives us a beginTime slightly into the future.
LOG(Animations, "%p AnimationState %s -> StartTimeSet (time is %f)", this, nameForState(m_animationState), param);
// We have a start time, set it, unless the startTime is already set
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
