Title: [189566] trunk
Revision
189566
Author
changseok...@collabora.com
Date
2015-09-10 02:10:11 -0700 (Thu, 10 Sep 2015)

Log Message

[GTK] Volume bar is broken
https://bugs.webkit.org/show_bug.cgi?id=145639

Reviewed by Philippe Normand.

Source/WebCore:

The ControlPart enum values' order has mismatched the one of values in CSSValueKeywords.in
after r180965. The MediaVolumeSliderPart should be prior to the MediaVolumeSliderContainerpart.

Tests: media/click-volume-bar-not-pausing.html
       media/volume-bar-empty-when-muted.html

* platform/ThemeTypes.h:

LayoutTests:

Unblock relevant tests. media/click-volume-bar-not-pausing.html, media/volume-bar-empty-when-muted.html

* platform/gtk/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (189565 => 189566)


--- trunk/LayoutTests/ChangeLog	2015-09-10 02:16:22 UTC (rev 189565)
+++ trunk/LayoutTests/ChangeLog	2015-09-10 09:10:11 UTC (rev 189566)
@@ -1,3 +1,14 @@
+2015-09-10  ChangSeok Oh  <changseok...@collabora.com>
+
+        [GTK] Volume bar is broken
+        https://bugs.webkit.org/show_bug.cgi?id=145639
+
+        Reviewed by Philippe Normand.
+
+        Unblock relevant tests. media/click-volume-bar-not-pausing.html, media/volume-bar-empty-when-muted.html
+
+        * platform/gtk/TestExpectations:
+
 2015-09-09  Dewei Zhu  <dewei_...@apple.com>
 
         Document.characterSet should return "UTF-8" by default.

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (189565 => 189566)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-09-10 02:16:22 UTC (rev 189565)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-09-10 09:10:11 UTC (rev 189566)
@@ -1350,7 +1350,6 @@
 webkit.org/b/142491 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Timeout ]
 
 webkit.org/b/142820 fast/images/animated-gif-body-outside-viewport.html [ Timeout Pass ]
-webkit.org/b/142491 media/click-volume-bar-not-pausing.html [ Timeout ]
 webkit.org/b/143473 editing/pasteboard/drag-and-drop-attachment-contenteditable.html [ Timeout ]
 
 webkit.org/b/143477 fast/writing-mode/broken-ideograph-small-caps.html [ Timeout Pass ]
@@ -2234,8 +2233,6 @@
 
 webkit.org/b/132235 fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-percent.html [ ImageOnlyFailure ]
 
-webkit.org/b/132253 media/volume-bar-empty-when-muted.html [ Failure ]
-
 webkit.org/b/132910 editing/pasteboard/drag-drop-paragraph-crasher.html [ Failure ]
 
 webkit.org/b/132914 http/tests/security/drag-drop-local-file.html [ Failure ]

Modified: trunk/Source/WebCore/ChangeLog (189565 => 189566)


--- trunk/Source/WebCore/ChangeLog	2015-09-10 02:16:22 UTC (rev 189565)
+++ trunk/Source/WebCore/ChangeLog	2015-09-10 09:10:11 UTC (rev 189566)
@@ -1,3 +1,18 @@
+2015-09-10  ChangSeok Oh  <changseok...@collabora.com>
+
+        [GTK] Volume bar is broken
+        https://bugs.webkit.org/show_bug.cgi?id=145639
+
+        Reviewed by Philippe Normand.
+
+        The ControlPart enum values' order has mismatched the one of values in CSSValueKeywords.in
+        after r180965. The MediaVolumeSliderPart should be prior to the MediaVolumeSliderContainerpart.
+
+        Tests: media/click-volume-bar-not-pausing.html
+               media/volume-bar-empty-when-muted.html
+
+        * platform/ThemeTypes.h:
+
 2015-09-09  Gyuyoung Kim  <gyuyoung....@webkit.org>
 
         Remove all uses of PassRefPtr in WebCore/svg

Modified: trunk/Source/WebCore/platform/ThemeTypes.h (189565 => 189566)


--- trunk/Source/WebCore/platform/ThemeTypes.h	2015-09-10 02:16:22 UTC (rev 189565)
+++ trunk/Source/WebCore/platform/ThemeTypes.h	2015-09-10 09:10:11 UTC (rev 189566)
@@ -38,8 +38,8 @@
     MediaFullScreenVolumeSliderThumbPart, MediaMuteButtonPart, MediaOverlayPlayButtonPart,
     MediaPlayButtonPart, MediaReturnToRealtimeButtonPart, MediaRewindButtonPart, MediaSeekBackButtonPart,
     MediaSeekForwardButtonPart, MediaSliderPart, MediaSliderThumbPart, MediaTimeRemainingPart,
-    MediaToggleClosedCaptionsButtonPart, MediaVolumeSliderContainerPart, MediaVolumeSliderMuteButtonPart,
-    MediaVolumeSliderPart, MediaVolumeSliderThumbPart,
+    MediaToggleClosedCaptionsButtonPart, MediaVolumeSliderPart, MediaVolumeSliderContainerPart,
+    MediaVolumeSliderMuteButtonPart, MediaVolumeSliderThumbPart,
     MenulistPart, MenulistButtonPart, MenulistTextPart, MenulistTextFieldPart, MeterPart, ProgressBarPart, ProgressBarValuePart,
     SliderHorizontalPart, SliderVerticalPart, SliderThumbHorizontalPart,
     SliderThumbVerticalPart, CaretPart, SearchFieldPart, SearchFieldDecorationPart,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to