[webkit-changes] [187284] branches/safari-600.8-branch

Thu, 23 Jul 2015 19:45:00 -0700

Title: [187284] branches/safari-600.8-branch

Diff

Modified: branches/safari-600.8-branch/LayoutTests/ChangeLog (187283 => 187284)


--- branches/safari-600.8-branch/LayoutTests/ChangeLog	2015-07-24 02:35:37 UTC (rev 187283)
+++ branches/safari-600.8-branch/LayoutTests/ChangeLog	2015-07-24 02:44:40 UTC (rev 187284)
@@ -1,5 +1,19 @@
 2015-07-23  Babak Shafiei  <[email protected]>
 
+        Merge r187248.
+
+    2015-07-23  Brady Eidson  <[email protected]>
+
+            Crash in WebPlatformStrategies::createPingHandle - Deref a null NetworkingContext.
+            <rdar://problem/21949735> and https://bugs.webkit.org/show_bug.cgi?id=147227
+
+            Reviewed by Alexey Proskuryakov.
+
+            * http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher-expected.txt: Added.
+            * http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher.html: Added.
+
+2015-07-23  Babak Shafiei  <[email protected]>
+
         Roll out r187241.
 
 2015-07-23  Babak Shafiei  <[email protected]>

Copied: branches/safari-600.8-branch/LayoutTests/http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher-expected.txt (from rev 187248, trunk/LayoutTests/http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher-expected.txt) (0 => 187284)


--- branches/safari-600.8-branch/LayoutTests/http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher-expected.txt	                        (rev 0)
+++ branches/safari-600.8-branch/LayoutTests/http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher-expected.txt	2015-07-24 02:44:40 UTC (rev 187284)
@@ -0,0 +1,6 @@
+CONSOLE MESSAGE: Refused to load the font 'http://127.0.0.1:8000/security/contentSecurityPolicy/example_font.woff' because it violates the following Content Security Policy directive: "font-src http://webkit.org".
+
+CONSOLE MESSAGE: Refused to load the font 'http://127.0.0.1:8000/security/contentSecurityPolicy/example_font.woff' because it violates the following Content Security Policy directive: "font-src http://webkit.org".
+
+The iframe below triggers a violation report creating the initial empty document. It should not crash the web process.
+

Copied: branches/safari-600.8-branch/LayoutTests/http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher.html (from rev 187248, trunk/LayoutTests/http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher.html) (0 => 187284)


--- branches/safari-600.8-branch/LayoutTests/http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher.html	                        (rev 0)
+++ branches/safari-600.8-branch/LayoutTests/http/tests/security/contentSecurityPolicy/user-style-sheet-font-crasher.html	2015-07-24 02:44:40 UTC (rev 187284)
@@ -0,0 +1,16 @@
+<html>
+<head>
+<meta content="font-src http://webkit.org; report-uri http://webkit.org/report;" http-equiv="Content-Security-Policy">
+<script>
+if (window.testRunner) {
+    testRunner.dumpAsText();
+    testRunner.waitUntilDone();
+    testRunner.addUserStyleSheet("@font-face { font-family: ExampleFont; src: url(example_font.woff); }", true);
+}
+</script>
+</head>
+<body>
+The iframe below triggers a violation report creating the initial empty document. It should not crash the web process.<br>
+<iframe src=""
+</body>
+</html>

Modified: branches/safari-600.8-branch/Source/WebKit2/ChangeLog (187283 => 187284)


--- branches/safari-600.8-branch/Source/WebKit2/ChangeLog	2015-07-24 02:35:37 UTC (rev 187283)
+++ branches/safari-600.8-branch/Source/WebKit2/ChangeLog	2015-07-24 02:44:40 UTC (rev 187284)
@@ -1,3 +1,17 @@
+2015-07-23  Babak Shafiei  <[email protected]>
+
+        Merge r187248.
+
+    2015-07-23  Brady Eidson  <[email protected]>
+
+            Crash in WebPlatformStrategies::createPingHandle - Deref a null NetworkingContext.
+            <rdar://problem/21949735> and https://bugs.webkit.org/show_bug.cgi?id=147227
+
+            Reviewed by Alexey Proskuryakov.
+
+            * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
+            (WebKit::WebPlatformStrategies::createPingHandle): Skip it if there's a null NetworkingContext.
+
 2015-07-21  Matthew Hanson  <[email protected]>
 
         Merge r185915. rdar://problem/21716368

Modified: branches/safari-600.8-branch/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp (187283 => 187284)


--- branches/safari-600.8-branch/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp	2015-07-24 02:35:37 UTC (rev 187283)
+++ branches/safari-600.8-branch/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp	2015-07-24 02:44:40 UTC (rev 187284)
@@ -279,6 +279,11 @@
 
 void WebPlatformStrategies::createPingHandle(NetworkingContext* networkingContext, ResourceRequest& request, bool shouldUseCredentialStorage)
 {
+    // It's possible that call to createPingHandle might be made during initial empty Document creation before a NetworkingContext exists.
+    // It is not clear that we should send ping loads during that process anyways.
+    if (!networkingContext)
+        return;
+
     auto& webProcess = WebProcess::shared();
     if (!webProcess.usesNetworkProcess()) {
         LoaderStrategy::createPingHandle(networkingContext, request, shouldUseCredentialStorage);

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to