Title: [186838] branches/safari-600.1.4.17-branch/Source/WebKit2
- Revision
- 186838
- Author
- [email protected]
- Date
- 2015-07-15 07:47:47 -0700 (Wed, 15 Jul 2015)
Log Message
REGRESSION (r186559): Follow-up fix to merge r183861 for <rdar://problem/21716677>
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::cleanup): Restore call to
deref() so we don't leak the NetworkResourceLoader.
Modified Paths
Diff
Modified: branches/safari-600.1.4.17-branch/Source/WebKit2/ChangeLog (186837 => 186838)
--- branches/safari-600.1.4.17-branch/Source/WebKit2/ChangeLog 2015-07-15 14:22:50 UTC (rev 186837)
+++ branches/safari-600.1.4.17-branch/Source/WebKit2/ChangeLog 2015-07-15 14:47:47 UTC (rev 186838)
@@ -1,3 +1,11 @@
+2015-07-15 David Kilzer <[email protected]>
+
+ REGRESSION (r186559): Follow-up fix to merge r183861 for <rdar://problem/21716677>
+
+ * NetworkProcess/NetworkResourceLoader.cpp:
+ (WebKit::NetworkResourceLoader::cleanup): Restore call to
+ deref() so we don't leak the NetworkResourceLoader.
+
2015-07-14 Lucas Forschler <[email protected]>
Merge r185877. <rdar://problem/21709291>
Modified: branches/safari-600.1.4.17-branch/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp (186837 => 186838)
--- branches/safari-600.1.4.17-branch/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2015-07-15 14:22:50 UTC (rev 186837)
+++ branches/safari-600.1.4.17-branch/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2015-07-15 14:47:47 UTC (rev 186838)
@@ -162,8 +162,11 @@
// Tell the scheduler about this finished loader soon so it can start more network requests.
NetworkProcess::shared().networkResourceLoadScheduler().scheduleRemoveLoader(this);
if (m_handle) {
+ // Explicit deref() balanced by a ref() in NetworkResourceLoader::start()
+ // This might cause the NetworkResourceLoader to be destroyed and therefore we do it last.
m_handle->setClient(nullptr);
m_handle = nullptr;
+ deref();
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
