Title: [186724] trunk/Source
Revision
186724
Author
[email protected]
Date
2015-07-11 21:23:21 -0700 (Sat, 11 Jul 2015)

Log Message

Web Inspector: Inspector should be able to be docked to the bottom of a narrow window
https://bugs.webkit.org/show_bug.cgi?id=146871

Reviewed by Timothy Hatcher.

Source/WebCore:

* inspector/InspectorFrontendClientLocal.cpp:

Source/WebInspectorUI:

* UserInterface/Views/Toolbar.css:
(@media (max-width: 539px)): Hide download button to fit search field into the screen.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:

Source/WebKit2:

* UIProcess/WebInspectorProxy.cpp:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCanAttach):
* WebProcess/WebPage/WebInspector.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (186723 => 186724)


--- trunk/Source/WebCore/ChangeLog	2015-07-12 04:14:29 UTC (rev 186723)
+++ trunk/Source/WebCore/ChangeLog	2015-07-12 04:23:21 UTC (rev 186724)
@@ -1,3 +1,12 @@
+2015-07-11  Nikita Vasilyev  <[email protected]>
+
+        Web Inspector: Inspector should be able to be docked to the bottom of a narrow window
+        https://bugs.webkit.org/show_bug.cgi?id=146871
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/InspectorFrontendClientLocal.cpp:
+
 2015-07-11  Joseph Pecoraro  <[email protected]>
 
         Update default link action sheets for app links

Modified: trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp (186723 => 186724)


--- trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp	2015-07-12 04:14:29 UTC (rev 186723)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClientLocal.cpp	2015-07-12 04:23:21 UTC (rev 186724)
@@ -63,7 +63,7 @@
 static const unsigned defaultAttachedHeight = 300;
 static const float minimumAttachedHeight = 250.0f;
 static const float maximumAttachedHeightRatio = 0.75f;
-static const float minimumAttachedWidth = 750.0f;
+static const float minimumAttachedWidth = 500.0f;
 static const float minimumAttachedInspectedWidth = 320.0f;
 
 class InspectorBackendDispatchTask {

Modified: trunk/Source/WebInspectorUI/ChangeLog (186723 => 186724)


--- trunk/Source/WebInspectorUI/ChangeLog	2015-07-12 04:14:29 UTC (rev 186723)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-07-12 04:23:21 UTC (rev 186724)
@@ -1,3 +1,13 @@
+2015-07-11  Nikita Vasilyev  <[email protected]>
+
+        Web Inspector: Inspector should be able to be docked to the bottom of a narrow window
+        https://bugs.webkit.org/show_bug.cgi?id=146871
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/Toolbar.css:
+        (@media (max-width: 539px)): Hide download button to fit search field into the screen.
+
 2015-07-11  Devin Rousso  <[email protected]>
 
         Web Inspector: Improve runtime of pseudo-element sidebar style ordering

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css (186723 => 186724)


--- trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-07-12 04:14:29 UTC (rev 186723)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css	2015-07-12 04:23:21 UTC (rev 186724)
@@ -198,3 +198,9 @@
         box-shadow: inset 0 0 1px 0 hsla(0, 0%, 0%, 0.1);
     }
 }
+
+@media (max-width: 539px) {
+    .toolbar .item.download {
+        display: none;
+    }
+}

Modified: trunk/Source/WebKit/mac/ChangeLog (186723 => 186724)


--- trunk/Source/WebKit/mac/ChangeLog	2015-07-12 04:14:29 UTC (rev 186723)
+++ trunk/Source/WebKit/mac/ChangeLog	2015-07-12 04:23:21 UTC (rev 186724)
@@ -1,3 +1,12 @@
+2015-07-11  Nikita Vasilyev  <[email protected]>
+
+        Web Inspector: Inspector should be able to be docked to the bottom of a narrow window
+        https://bugs.webkit.org/show_bug.cgi?id=146871
+
+        Reviewed by Timothy Hatcher.
+
+        * WebCoreSupport/WebInspectorClient.mm:
+
 2015-07-07  Brady Eidson  <[email protected]>
 
         HTTP Auth cached after disabling private browsing/reset.

Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm (186723 => 186724)


--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm	2015-07-12 04:14:29 UTC (rev 186723)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm	2015-07-12 04:23:21 UTC (rev 186724)
@@ -59,7 +59,7 @@
 
 using namespace WebCore;
 
-static const CGFloat minimumWindowWidth = 750;
+static const CGFloat minimumWindowWidth = 500;
 static const CGFloat minimumWindowHeight = 400;
 static const CGFloat initialWindowWidth = 1000;
 static const CGFloat initialWindowHeight = 650;

Modified: trunk/Source/WebKit2/ChangeLog (186723 => 186724)


--- trunk/Source/WebKit2/ChangeLog	2015-07-12 04:14:29 UTC (rev 186723)
+++ trunk/Source/WebKit2/ChangeLog	2015-07-12 04:23:21 UTC (rev 186724)
@@ -1,3 +1,15 @@
+2015-07-11  Nikita Vasilyev  <[email protected]>
+
+        Web Inspector: Inspector should be able to be docked to the bottom of a narrow window
+        https://bugs.webkit.org/show_bug.cgi?id=146871
+
+        Reviewed by Timothy Hatcher.
+
+        * UIProcess/WebInspectorProxy.cpp:
+        * UIProcess/mac/WebInspectorProxyMac.mm:
+        (WebKit::WebInspectorProxy::platformCanAttach):
+        * WebProcess/WebPage/WebInspector.cpp:
+
 2015-07-11  Joseph Pecoraro  <[email protected]>
 
         Allow clients to opt-out of default app link link actions

Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (186723 => 186724)


--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp	2015-07-12 04:14:29 UTC (rev 186723)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp	2015-07-12 04:23:21 UTC (rev 186724)
@@ -52,7 +52,7 @@
 
 namespace WebKit {
 
-const unsigned WebInspectorProxy::minimumWindowWidth = 750;
+const unsigned WebInspectorProxy::minimumWindowWidth = 500;
 const unsigned WebInspectorProxy::minimumWindowHeight = 400;
 
 const unsigned WebInspectorProxy::initialWindowWidth = 1000;

Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (186723 => 186724)


--- trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm	2015-07-12 04:14:29 UTC (rev 186723)
+++ trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm	2015-07-12 04:23:21 UTC (rev 186724)
@@ -490,7 +490,7 @@
 
     static const float minimumAttachedHeight = 250;
     static const float maximumAttachedHeightRatio = 0.75;
-    static const float minimumAttachedWidth = 750;
+    static const float minimumAttachedWidth = 500;
 
     NSRect inspectedViewFrame = inspectedView.frame;
 

Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp (186723 => 186724)


--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp	2015-07-12 04:14:29 UTC (rev 186723)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspector.cpp	2015-07-12 04:23:21 UTC (rev 186724)
@@ -49,7 +49,7 @@
 
 static const float minimumAttachedHeight = 250;
 static const float maximumAttachedHeightRatio = 0.75;
-static const float minimumAttachedWidth = 750;
+static const float minimumAttachedWidth = 500;
 
 namespace WebKit {
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to