Title: [186716] trunk/Source/WebKit2
- Revision
- 186716
- Author
- [email protected]
- Date
- 2015-07-11 14:30:33 -0700 (Sat, 11 Jul 2015)
Log Message
Remove incorrect overriding of inputAssistantItem in WKContentView.
https://bugs.webkit.org/show_bug.cgi?id=146863
rdar://problem/21507154
Reviewed by Sam Weinig.
Correction to the patch in r186713.
We need to provide the inputAssistantItem from the responder.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView inputAccessoryView]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (186715 => 186716)
--- trunk/Source/WebKit2/ChangeLog 2015-07-11 20:35:45 UTC (rev 186715)
+++ trunk/Source/WebKit2/ChangeLog 2015-07-11 21:30:33 UTC (rev 186716)
@@ -1,3 +1,17 @@
+2015-07-11 Enrica Casucci <[email protected]>
+
+ Remove incorrect overriding of inputAssistantItem in WKContentView.
+ https://bugs.webkit.org/show_bug.cgi?id=146863
+ rdar://problem/21507154
+
+ Reviewed by Sam Weinig.
+
+ Correction to the patch in r186713.
+ We need to provide the inputAssistantItem from the responder.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView inputAccessoryView]):
+
2015-07-11 Commit Queue <[email protected]>
Unreviewed, rolling out r186689 and r186710.
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (186715 => 186716)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-07-11 20:35:45 UTC (rev 186715)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-07-11 21:30:33 UTC (rev 186716)
@@ -211,6 +211,12 @@
+ (BOOL)_addCompletion:(void(^)(BOOL))completion;
@end
+#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000
+@interface UIWebFormAccessory (StagingToRemove)
+- (id)initWithInputAssistantItem:(UITextInputAssistantItem *)inputAssistantItem;
+@end
+#endif
+
@interface WKFormInputSession : NSObject <_WKFormInputSession>
- (instancetype)initWithContentView:(WKContentView *)view userObject:(NSObject <NSSecureCoding> *)userObject;
@@ -1251,7 +1257,12 @@
- (UIView *)inputAccessoryView
{
if (!_formAccessoryView) {
- _formAccessoryView = adoptNS([[UIWebFormAccessory alloc] init]);
+#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000
+ if ([UIWebFormAccessory instancesRespondToSelector:@selector(initWithInputAssistantItem:)])
+ _formAccessoryView = adoptNS([[UIWebFormAccessory alloc] initWithInputAssistantItem:[self inputAssistantItem]]);
+ else
+#endif
+ _formAccessoryView = adoptNS([[UIWebFormAccessory alloc] init]);
[_formAccessoryView setDelegate:self];
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
