Title: [186141] trunk/Source/WebInspectorUI
- Revision
- 186141
- Author
- [email protected]
- Date
- 2015-06-30 15:58:05 -0700 (Tue, 30 Jun 2015)
Log Message
Web Inspector: ProfileNode cleanup
https://bugs.webkit.org/show_bug.cgi?id=146472
Patch by Joseph Pecoraro <[email protected]> on 2015-06-30
Reviewed by Timothy Hatcher.
* UserInterface/Models/ProfileNode.js:
(WebInspector.ProfileNode):
Use Array.prototype.every instead of reduce.
Correct the name of a function to be what callers expect!
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (186140 => 186141)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-06-30 22:51:16 UTC (rev 186140)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-06-30 22:58:05 UTC (rev 186141)
@@ -1,5 +1,17 @@
2015-06-30 Joseph Pecoraro <[email protected]>
+ Web Inspector: ProfileNode cleanup
+ https://bugs.webkit.org/show_bug.cgi?id=146472
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Models/ProfileNode.js:
+ (WebInspector.ProfileNode):
+ Use Array.prototype.every instead of reduce.
+ Correct the name of a function to be what callers expect!
+
+2015-06-30 Joseph Pecoraro <[email protected]>
+
Web Inspector: iOS 8: Profile Nodes not showing in _javascript_ Timeline
https://bugs.webkit.org/show_bug.cgi?id=146471
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js (186140 => 186141)
--- trunk/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js 2015-06-30 22:51:16 UTC (rev 186140)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ProfileNode.js 2015-06-30 22:58:05 UTC (rev 186141)
@@ -34,9 +34,9 @@
console.assert(id);
console.assert(calls instanceof Array);
console.assert(calls.length >= 1);
- console.assert(calls.reduce(function(previousValue, call) { return previousValue && call instanceof WebInspector.ProfileNodeCall; }, true));
+ console.assert(calls.every(function(call) { return call instanceof WebInspector.ProfileNodeCall; }));
console.assert(childNodes instanceof Array);
- console.assert(childNodes.reduce(function(previousValue, node) { return previousValue && node instanceof WebInspector.ProfileNode; }, true));
+ console.assert(childNodes.every(function(node) { return node instanceof WebInspector.ProfileNode; }));
this._id = id;
this._type = type || WebInspector.ProfileNode.Type.Function;
@@ -207,7 +207,7 @@
// Private
- _computeTotalTimes()
+ _computeTotalTimesIfNeeded()
{
if (this._computedTotalTimes)
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
